mz772: multi-target builds via a JSON bakefile#773
Draft
mzihlmann wants to merge 2 commits into
Draft
Conversation
mzihlmann
changed the title
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
mzihlmann
force-pushed
the
mz772-multi-target-bake
branch
10 times, most recently
from
83e5d36 to
82eac4d
Compare
mzihlmann
force-pushed
the
mz772-multi-target-bake
branch
from
82eac4d to
99478dc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
bakesubcommand that builds the target named in a small JSON bakefile, with the target stage and push destination owned by the file instead of CLI flags. Everything else (context, dockerfile, build args, cache, registry) stays on the usual flags and is shared, so the bakefile only carries what varies per image. The format is versioned so it can grow into per-target build args and matrix expansion without a breaking change.This first step handles a single target per bakefile. Building several targets in one pass over the shared stage graph and pushing each is the follow-up, which is where the performance win lands.
Draft until the executor multi-push work is in.
Closes #772